garydgregory commented on a change in pull request #91:
URL:
https://github.com/apache/commons-configuration/pull/91#discussion_r551067674
##########
File path: src/test/java/org/apache/commons/configuration2/test/HsqlDB.java
##########
@@ -35,7 +35,7 @@
public class HsqlDB
{
private Connection connection = null;
- private static Log log = LogFactory.getLog(HsqlDB.class);
+ private static final Log log = LogFactory.getLog(HsqlDB.class);
Review comment:
Again, please, please, please, review ALL of your changes. If you make a
static final, then the name should become UPPER CASE by convention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
