MaxKellermann commented on pull request #154: URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774433274
> @MaxKellermann, @garydgregory what do you think if we break this PR into a few other smaller PR's, I think that would be easier to review, and grouping that way in case some bugs/issue is raised later, it might be easier to look at the changelog and see what could be causing it. If that makes it easier for you, OK for me. Here's part 1: https://github.com/apache/commons-vfs/pull/158 As soon as you merge it, I'll rebase this PR and drop the merged commits. In projects I maintain, if I like some obvious-good commits, I cherry-pick them and then start discussing the others, and I expect the submitter to rebase the PR with only the unmerged commits remaining. What I certainly would never do is fold all PR commits into one large commit like you did with https://github.com/apache/commons-vfs/pull/155 - 3 commits were folded into one (https://github.com/apache/commons-vfs/commit/9c4302e4559acb1e2a627f57f49105c54fe09895). That loses a lot of context, makes the resulting commit hard to read/verify/understand, and makes git-bisect very hard. That's your project, your maintenance decision, so I'm not going to argue, just mentioning it because that's one thing that would make project management hard for me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
