[
https://issues.apache.org/jira/browse/COMPRESS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281661#comment-17281661
]
Peter Lee commented on COMPRESS-564:
------------------------------------
Hi, Michael. This looks good to me.
It seems zstd-jni offers RecyclingBufferPool and NoPool, and it supports custom
BufferPool implemented by users.
I prefer providing only RecyclingBufferPool and NoPool to users, instead of
custom BufferPool. But I don't like using a boolean like the ones did in Spark
and Parquet - there may be more BufferPools in zstd-jni in the future and we
can't ensure it's always a config with only 2 choices.
WDYT?
> Support ZSTD JNI BufferPool
> ---------------------------
>
> Key: COMPRESS-564
> URL: https://issues.apache.org/jira/browse/COMPRESS-564
> Project: Commons Compress
> Issue Type: New Feature
> Reporter: Michael Heuer
> Priority: Major
>
> commons-compress should allow configuration of zstd-jni's use of
> RecyclingBufferPool vs NoPool. zstd-jni defaults to not pool buffers by
> default
> [https://github.com/luben/zstd-jni/commit/f7c8279bc162c8c8b1964948d0f3b309ad715311]
>
> Please see pull requests for similar issues in Apache Spark
> [https://github.com/apache/spark/pull/31453]
> and Apache Parquet projects
> [https://github.com/apache/parquet-mr/pull/865]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
