[ 
https://issues.apache.org/jira/browse/COMPRESS-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281952#comment-17281952
 ] 

Michael Heuer commented on COMPRESS-564:
----------------------------------------

Thank you [~peterlee] for the feedback!

I haven't seen other examples of runtime configuration in commons-compress 
(although I haven't looked too closely yet), I could put together a PR if there 
is a pattern to follow.

Note another possible configuration regarding zstd-jni, whether to use 
implementations with finalizers
[https://github.com/luben/zstd-jni/issues/83]
[https://github.com/luben/zstd-jni/commit/be9be47fae23b5510344b67f9c0f7b258c2f5890]

> Support ZSTD JNI BufferPool
> ---------------------------
>
>                 Key: COMPRESS-564
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-564
>             Project: Commons Compress
>          Issue Type: New Feature
>            Reporter: Michael Heuer
>            Priority: Major
>
> commons-compress should allow configuration of zstd-jni's use of 
> RecyclingBufferPool vs NoPool.  zstd-jni defaults to not pool buffers by 
> default
> [https://github.com/luben/zstd-jni/commit/f7c8279bc162c8c8b1964948d0f3b309ad715311]
>  
> Please see pull requests for similar issues in Apache Spark
> [https://github.com/apache/spark/pull/31453]
> and Apache Parquet projects
> [https://github.com/apache/parquet-mr/pull/865]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to