MaxKellermann commented on pull request #166: URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-796840066
> Oh, my, there is an `openStreams` integer variable... smile Why isn't that used instead of `fileContentThreadData`? Because `FileContentThreadData` is per-thread, and `openStreams` counts all streams of all threads. Your change eliminates that distinction. The real question is: why was there ever that distinction? `FileContentThreadData` was added in 2004 by commit f299cbf1c894817bf70c96b8efd5ad80741d445b, and `openStreams` was added in 2005 by commit b1f1bbf6f576ececada5add29d6eda9cbce68eda, both by the same guy. Both commits look questionable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
