MaxKellermann commented on pull request #166: URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-796857023
Also be careful to document what must be locked by the caller. It is dangerous that `getFileContentThreadData()` is not `synchronized` anymore, but you didn't document that synchronization is the caller's responsibility. In cases like that, I'd leave the `synchronized` in - this only adds negligible overhead, but is safe-by-default. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
