MaxKellermann commented on pull request #166: URL: https://github.com/apache/commons-vfs/pull/166#issuecomment-797604245
Since the leak bug has always been there, and given the bad existing code design, I guess adding a `null` check is the best we can do short-term. This restores the old behavior, with the old bug, but without crashing. I don't like that, but I dislike so much about this code. If you write a PR, maybe add a TODO comment explaining the bug and why these checks should not be necessary, to give other people an overview of what's wrong. All kludges should be well-documented to avoid confusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
