yavuzkavus commented on a change in pull request #124:
URL: https://github.com/apache/commons-imaging/pull/124#discussion_r593957568
##########
File path:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java
##########
@@ -202,6 +209,11 @@ public PhotoshopApp13Data parsePhotoshopSegment(final
byte[] bytes, final boolea
// Debug.debug("recordSize", recordSize + " (0x"
// + Integer.toHexString(recordSize) + ")");
+ if( recordNumber==IptcConstants.IPTC_ENVELOPE_RECORD_NUMBER &&
recordType==ENV_TAG_CODED_CHARACTER_SET ) {
Review comment:
Yes, there some others :) For example, there is not space between if and
opening paranthes. I fixed all. I pushed the new changes.
There have been many commits for this change. If it is merged, is it
possible to convert it as single commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
