yavuzkavus commented on pull request #124:
URL: https://github.com/apache/commons-imaging/pull/124#issuecomment-798977678


   > 
   > 
   > Code looks really good @yavuzkavus ! Only thing that appears to be missing 
is a test. I am not sure if I have any file with IPTC metadata + some different 
encodings, or if we would have to craft or search for them online. Do you have 
any photo @yavuzkavus ? if not we can leave it open just until we locate some 
and write the tests and then merge it. I've updated the issue in JIRA with the 
fixVersion=alpha-3, the next release.
   > 
   > Thanks a lot for the PR!
   
   Created a new image using photoshop, with unicode iptc metadata.
   
   The image:
   
![iptc-test](https://user-images.githubusercontent.com/8396809/111083453-c07f1880-851e-11eb-8b61-2757f7d934bf.jpg)
   
   Inspection of the he metadata of the image on iptc.org site:
   
![metadata](https://user-images.githubusercontent.com/8396809/111083566-44d19b80-851f-11eb-8970-6e348b82366a.png)
   
   The metadata contains a description containing some non-ascii chars and 10 
keywrods of "Thanks" in different languages including Arabic, Hebrew, Japanese, 
Chinese and some other languages.
   
   I am reading data using the code on my machine and it can read all metadata 
in correct forms and also can write unicode data to the image correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to