ath0mas commented on a change in pull request #162:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/162#discussion_r544707203
##########
File path: src/ios/CDVCapture.m
##########
@@ -266,7 +267,18 @@ - (void)captureVideo:(CDVInvokedUrlCommand*)command
// iOS 4.0
if ([pickerController
respondsToSelector:@selector(cameraCaptureMode)]) {
pickerController.cameraCaptureMode =
UIImagePickerControllerCameraCaptureModeVideo;
- // pickerController.videoQuality =
UIImagePickerControllerQualityTypeHigh;
+ switch((int)([quality doubleValue]*10)) {
+ case 0:
+ pickerController.videoQuality =
UIImagePickerControllerQualityTypeLow;
+ break;
+ case 10:
+ pickerController.videoQuality =
UIImagePickerControllerQualityTypeHigh;
+ break;
+ default:
+ pickerController.videoQuality =
UIImagePickerControllerQualityTypeMedium;
Review comment:
This `default` case does not match the expected default value of `1`
(here it would correspond to the new value `0.5`).
See README info, previously for Android only, but shared between Android and
iOS with this PR
> value of `1` ( the default )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
