ath0mas commented on a change in pull request #162:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/162#discussion_r592801955
##########
File path: src/ios/CDVCapture.m
##########
@@ -266,7 +267,18 @@ - (void)captureVideo:(CDVInvokedUrlCommand*)command
// iOS 4.0
if ([pickerController
respondsToSelector:@selector(cameraCaptureMode)]) {
pickerController.cameraCaptureMode =
UIImagePickerControllerCameraCaptureModeVideo;
- // pickerController.videoQuality =
UIImagePickerControllerQualityTypeHigh;
+ switch((int)([quality doubleValue]*10)) {
Review comment:
Is this operation always safe to do here and necessary, or shouldn't we
have a more "direct" _switch_ on `quality` value itself?
For example if the user has bad options `{quality: null}`, or _undefined_, a
string, a boolean, or any wrong/not number value for `quality` param. Or maybe
the use of `NSNumber* quality = [options objectForKey:@"quality"];` will fail
first in those cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
