dpogue commented on pull request #1050: URL: https://github.com/apache/cordova-ios/pull/1050#issuecomment-754726896
In concept this looks good. I suspect `CDVWebViewEngineProtocol initWithFrame:configuration:` will have to be a separate method from the existing `CDVWebViewEngineProtocol initWithFrame:` to maintain backwards compatibility with [existing](https://github.com/ionic-team/cordova-plugin-ionic-webview/blob/master/src/ios/CDVWKWebViewEngine.m#L117) [webview](https://github.com/bpresles/cordova-plugin-uiwebview-engine/blob/master/src/ios/BPRUIWebViewEngine.m#L39) plugins, and then we'll need to conditionally decide which one to call based on the engine class responding to it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
