msmtamburro commented on a change in pull request #1050:
URL: https://github.com/apache/cordova-ios/pull/1050#discussion_r552981520
##########
File path: CordovaLib/Classes/Public/CDVViewController.m
##########
@@ -505,9 +505,10 @@ - (UIView*)newCordovaViewWithFrame:(CGRect)bounds
self.webViewEngine =
[[NSClassFromString(defaultWebViewEngineClass) alloc] initWithFrame:bounds];
}
} else {
- self.webViewEngine = [[NSClassFromString(defaultWebViewEngineClass)
alloc] initWithFrame:bounds];
+ WKWebViewConfiguration *config = [self
respondsToSelector:@selector(configuration)] ? [self configuration] : nil;
+ self.webViewEngine = [[NSClassFromString(defaultWebViewEngineClass)
alloc] initWithFrame:bounds configuration:config];
Review comment:
Since the change was more extensive than expected, I raised it in
another branch on my fork:
https://github.com/msmtamburro/cordova-ios/pull/1/files
If it makes sense, I'll merge it in to this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
