ath0mas opened a new pull request #1213: URL: https://github.com/apache/cordova-android/pull/1213
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Mixed default values for `create` between cli doc, cordova-android and cordova-ios. And wrong project name if with spaces and accents: see #1210 ### Description <!-- Describe your changes in detail --> Package ids were mostly correct but not all, and same for project name. Suggested proper defaults: - **id** / package name: `io.cordova.helloCordova` - **name** / project name: `Hello Cordova` See linked PRs: apache/cordova-cli#554, apache/cordova-ios#1100 And - Fix #1210: project name not transformed anymore (was replacing non-word characters with underscores), because there is no known limitation with it, project creation and all still work fine, and cordova-ios does it the same way - small update on main Readme to update/add details for use and test ### Testing <!-- Please describe in detail how you tested your changes. --> `npm test` success + project creation, open and run from IDE into emulator Fine on 10.0.0-dev and same for 9.2.0-dev 👍 (would be nice to backport this into a 9.x fix release) ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
