jskrepnek opened a new pull request #1342: URL: https://github.com/apache/cordova-android/pull/1342
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> fixes: https://github.com/apache/cordova-android/issues/1322 ### Description `shouldAllowRequest` will throw an exception for all URLS that are not in the navigation allowed list. This changes safely tests the result of `shouldAllowNavigation`, avoiding the exception and allowing for the execution to continue to see if the URL is in the request allowed list. ### Testing <!-- Please describe in detail how you tested your changes. --> Incorporating this change into our project successfully allows expected network requests that previously were allowed with the whitelist plugin. ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
