erisu commented on pull request #226: URL: https://github.com/apache/cordova-paramedic/pull/226#issuecomment-941903575
I have not tested these changes but are you 100% positive that they are working correctly from your testing? Looking at the code from this link shows that the returned result is parsed by regular expressions to grab the simulator IDs. https://github.com/apache/cordova-paramedic/blob/master/lib/utils/utilities.js#L134 As you pointed out in your ticket description: > it looks like xcrun xctrace list devices is a good replacement, though the output does not line up exactly. If the regular expression is not updated, I do not see how your testing of this PR works cause the regular expression is looking for the old pattern. Can you please confirm this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
