breautek commented on code in PR #102:
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/102#discussion_r977062042
##########
src/ios/CDVOrientation.m:
##########
@@ -80,7 +80,13 @@ -(void)screenOrientation:(CDVInvokedUrlCommand *)command
}
if (value != nil) {
_isLocked = true;
- [[UIDevice currentDevice] setValue:value
forKey:@"orientation"];
+ if (@available(iOS 16.0, *)) {
+ #if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5 //
Xcode 14 and iOS 16, or greater
+ [self.viewController
setNeedsUpdateOfSupportedInterfaceOrientations];
+ #endif
Review Comment:
So I take it if the application was compiled using XCode 13, and this was
ran on an iOS 16 device, this effectively becomes a no-op, as it will enter the
`if (@available(iOS 16.0, *)) {` condition, but only XCode >= 14 will actually
have code.
Is my understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
