breautek commented on PR #102: URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/102#issuecomment-1255165334
No worries, I'm not an really iOS developer either, I don't even personally own a mac. So unfortunately I cannot be much help when it comes to testing or experimenting with different solutions. Last night I fixed the chrome test, so if you rebase the PR, the chrome test should start passing. I think the solution does work if running XCode 14 (based on my reading of the Apple documentation). I understand that the code won't compile unless if you're running XCode 14, because iPhoneSDKs are tied to the xcode version. I believe `#if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5 // Xcode 14 and iOS 16, or greater` is meant to address this, but it doesn't seem to be working properly (and I personally don't why or what is the alternative solution). What we could do perhaps is to simply not use this compiler macro check and treat this as a breaking change PR. We will need to update our GitHub Actions to use XCode 14 or later first before we can accept this PR. Our current testing environment is outdated anyway, considering that Apple doesn't even allow XCode 11 to be used for publishing apps. @erisu or @NiklasMerz Do you have any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
