TylerBreau opened a new pull request, #181: URL: https://github.com/apache/cordova-common/pull/181
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected All ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Currently, adding attributes to the XML tags requires a lot of repos to update. cordova-common to read the new XML tag. cordova-lib and cordova cli need to update their dependencies. People need to update cordova-cli to have the cordova-common update. Each platform that wants to use the new attribute needs to be updated. cordova-docs also needs to be updated. Depending on the number of platforms that needs the update you're looking at 5 or more repos requiring an update, even when it's simply add a brand new attribute to an XML tag. This PR updates the XML parsing code to passthrough all attributes. Existing attributes are parsed in the same way there parsed before. New attributes will be passed through without any addition parsing. The intention is to stop requiring cordova-common updates in order to add attributes to XML tags. The benefit of this PR is that it removes need to update 3 repos when modifying supported XML tags. Those 3 repos being cordova-common, cordova-lib, and cordova-cli. ### Description <!-- Describe your changes in detail --> Copies all attributes from XML tags to the return object in the respective XML tag get functions. Existing attributes are still parsed in the exact same way as before. E.X framework attribute "embed" is still passed through isStrTrue. I don't believe any cordova-docs updates are required. ### Testing <!-- Please describe in detail how you tested your changes. --> I've ran npm test on cordova-common, cordova-lib, cordova-cli. lib and cli were updated with the cordova-common change. I've ran these changes on my company's app. An update in my company's attribute is requiring me to add an new attribute to the framework tag. I've tested adding a new attribute to cordova-ios with my company's app using these changes. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
