TylerBreau commented on PR #181: URL: https://github.com/apache/cordova-common/pull/181#issuecomment-1284002004
> This looks good, and definitely helps make it easier for platforms to support new attributes in the future! > > It would be good to add unit tests to show that custom attributes do, in fact, get passed through and returned by the methods after this change. Yea I was just looking at the unit tests, seeing there's basically no detailed testing for the XML parsing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
