RaddishIoW commented on issue #240: URL: https://github.com/apache/cordova-electron/issues/240#issuecomment-1285316286
Hmm... So I've been digging around a little in the code to get prepared for this, and it seems to me that this should already be possible, as there is code for handling overridable per-platform config options - however, there is a function called `__validateUserPlatformBuildSettings` which gets called and throws an error if there are any extra keys in the config which aren't `platformConfigs.package || platformConfigs.arch || platformConfigs.signing`. I can't see why this is there? The code supports other keys in the config, and there is even a test in `tests/spec/unit/lib/build.spec.js` which tests that this works! IRL, the build never gets to this point with any of the overridable keys in the platform configs as it's stopped by the `__validateUserPlatformBuildSettings` function call first. Can anyone shed any light on this? This code comes from PR #4 waaaay back... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
