profenpoche commented on code in PR #102:
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/102#discussion_r1021262786
##########
src/ios/CDVOrientation.m:
##########
@@ -80,7 +80,13 @@ -(void)screenOrientation:(CDVInvokedUrlCommand *)command
}
if (value != nil) {
_isLocked = true;
- [[UIDevice currentDevice] setValue:value
forKey:@"orientation"];
+ if (@available(iOS 16.0, *)) {
+ #if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5 //
Xcode 14 and iOS 16, or greater
+ [self.viewController
setNeedsUpdateOfSupportedInterfaceOrientations];
+ #endif
+ } else {
+ [UINavigationController
attemptRotationToDeviceOrientation];
Review Comment:
Hello and thanks for the fork :)
the change suggested by msmtamburro on line 88 is indeed important because
we need to set value set in javascript and not come back to default device
orientation (which is the default orientation calculate by device giroscope and
used before in the code (line 75-79) when "unlock" is called
(orientationMask==15))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
