jaydrogers commented on code in PR #102:
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/102#discussion_r977990646
##########
src/ios/CDVOrientation.m:
##########
@@ -80,7 +80,13 @@ -(void)screenOrientation:(CDVInvokedUrlCommand *)command
}
if (value != nil) {
_isLocked = true;
- [[UIDevice currentDevice] setValue:value
forKey:@"orientation"];
+ if (@available(iOS 16.0, *)) {
+ #if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5 //
Xcode 14 and iOS 16, or greater
+ [self.viewController
setNeedsUpdateOfSupportedInterfaceOrientations];
+ #endif
+ } else {
+ [UINavigationController
attemptRotationToDeviceOrientation];
Review Comment:
Not sure, but if you have any suggestions or fixes, feel free to submit them
on my batch branch.
I'll definitely get them merged
https://github.com/jaydrogers/cordova-plugin-screen-orientation/tree/patch-1
Sorry I can't be much help on this other than the dude who opened the PR 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
