breautek commented on PR #1550: URL: https://github.com/apache/cordova-android/pull/1550#issuecomment-1406532626
In addition to what Erisu said, please have a look at the [unit tests](https://github.com/apache/cordova-android/pull/1550/checks), there are a few lint checks that are failing. ``` Error: 741:13 error 'monochromeVal' is never reassigned. Use 'const' instead prefer-const Error: 780:9 error Expected space(s) after "if" keyword-spacing Error: 793:34 error Strings must use singlequote quotes Error: 794:9 error Expected space(s) after "if" keyword-spacing Error: 849:9 error Expected space(s) after "if" keyword-spacing ``` I think the overall test will fail until we have the cordova-common changes merged and released, but we should be able to correct the lint errors in the meantime. These are all trivial errors that eslint should be able to fix automatically using `npm run lint:fix`. The `npm run lint` command can also be ran to run the linter locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
