erisu commented on code in PR #1550:
URL: https://github.com/apache/cordova-android/pull/1550#discussion_r1150069519
##########
package.json:
##########
@@ -26,7 +26,7 @@
"license": "Apache-2.0",
"dependencies": {
"android-versions": "^1.7.0",
- "cordova-common": "^4.0.2",
+ "cordova-common": "^4.0.2",
Review Comment:
If you can also review the commit changes one time to confirm nothing was
lost, that will be great.
So far everything looks great on my end.
There is one test failure,
> ✗ Test#010 : Should detech adaptive icon with vector foreground and throws
error for missing backwards compatability settings. (0.013 sec)
> - Expected function to throw CordovaError: For the following icons
with the density of: mdpi, adaptive foreground with a defined color or vector
can not be used as a standard fallback icon for older Android devices. To
support older Android environments, please provide a value for the src
attribute., but it threw Error: ENOENT: no such file or directory, open
'/home/runner/work/cordova-android/cordova-android/platforms/android/app/src/main/res/mipmap-mdpi-v26/ic_launcher.xml'.
I believe it is related to this change:
https://github.com/apache/cordova-android/pull/1550/files#diff-c6eb45ef369fbd224eff9d2927942c4732c0e8ffe2779a74e05aee9f15b5bdb2L308-R314
It seems the `.xml` file extension was changed to `.png` while the test is
related to `vector foreground`. I think this is an incorrect change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
