dpogue opened a new pull request, #1522:
URL: https://github.com/apache/cordova-ios/pull/1522

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Pointing a relative path to CordovaLib in the node_modules folder means that 
the Xcode project is no longer self-contained, which is significant change in 
terms of assumptions people can make about the project files in CI environments 
(i.e., preparing all platforms once, then copying just the platform folders to 
different runners to build).
   
   
   ### Description
   <!-- Describe your changes in detail -->
   We now copy the CordovaLib folder into a `platforms/ios/packages` directory 
and point to it there. (We will need to do the same for SPM plugins, which 
sorta turns out to our advantage...)
   
   As a side effect, it seemed worth bringing back the `--link` option to 
continue pointing to node_modules for easier development.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tested with mobilespec and unit tests.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to