erisu commented on PR #1521:
URL: https://github.com/apache/cordova-ios/pull/1521#issuecomment-2598229736

   - Building the mobilespec project with main branch fails as stated in PR 
description.
   - Building the mobilespec project with this PR shows a successful build.
   
   There is warnings with the build though:
   
   ```
   While building module 'Cordova':
   In file included from <module-includes>:1:
   In file included from 
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/Cordova.h:25:
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:45:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      45 | extern const NSNotificationName CDVPageDidLoadNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:45:14:
 note: insert '_Nullable' if the
         pointer may be null
      45 | extern const NSNotificationName CDVPageDidLoadNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:45:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      45 | extern const NSNotificationName CDVPageDidLoadNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:46:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      46 | extern const NSNotificationName CDVPluginHandleOpenURLNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:46:14:
 note: insert '_Nullable' if the
         pointer may be null
      46 | extern const NSNotificationName CDVPluginHandleOpenURLNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:46:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      46 | extern const NSNotificationName CDVPluginHandleOpenURLNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:47:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      47 | extern const NSNotificationName 
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification CDV_DEPRECATED(8, 
"Find sourceApplication and annotations in the userInfo of the CDVPlugi...
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:47:14:
 note: insert '_Nullable' if the
         pointer may be null
      47 | extern const NSNotificationName 
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification CDV_DEPRECATED(8, 
"Find sourceApplication and annotations in the userInfo of the CDVPlugi...
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:47:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      47 | extern const NSNotificationName 
CDVPluginHandleOpenURLWithAppSourceAndAnnotationNotification CDV_DEPRECATED(8, 
"Find sourceApplication and annotations in the userInfo of the CDVPlugi...
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:48:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      48 | extern const NSNotificationName CDVPluginResetNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:48:14:
 note: insert '_Nullable' if the
         pointer may be null
      48 | extern const NSNotificationName CDVPluginResetNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:48:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      48 | extern const NSNotificationName CDVPluginResetNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:49:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      49 | extern const NSNotificationName CDVViewWillAppearNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:49:14:
 note: insert '_Nullable' if the
         pointer may be null
      49 | extern const NSNotificationName CDVViewWillAppearNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:49:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      49 | extern const NSNotificationName CDVViewWillAppearNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:50:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      50 | extern const NSNotificationName CDVViewDidAppearNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:50:14:
 note: insert '_Nullable' if the
         pointer may be null
      50 | extern const NSNotificationName CDVViewDidAppearNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:50:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      50 | extern const NSNotificationName CDVViewDidAppearNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:51:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      51 | extern const NSNotificationName CDVViewWillDisappearNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:51:14:
 note: insert '_Nullable' if the
         pointer may be null
      51 | extern const NSNotificationName CDVViewWillDisappearNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:51:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      51 | extern const NSNotificationName CDVViewWillDisappearNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:52:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      52 | extern const NSNotificationName CDVViewDidDisappearNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:52:14:
 note: insert '_Nullable' if the
         pointer may be null
      52 | extern const NSNotificationName CDVViewDidDisappearNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:52:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      52 | extern const NSNotificationName CDVViewDidDisappearNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:53:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      53 | extern const NSNotificationName 
CDVViewWillLayoutSubviewsNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:53:14:
 note: insert '_Nullable' if the
         pointer may be null
      53 | extern const NSNotificationName 
CDVViewWillLayoutSubviewsNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:53:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      53 | extern const NSNotificationName 
CDVViewWillLayoutSubviewsNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:54:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      54 | extern const NSNotificationName CDVViewDidLayoutSubviewsNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:54:14:
 note: insert '_Nullable' if the
         pointer may be null
      54 | extern const NSNotificationName CDVViewDidLayoutSubviewsNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:54:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      54 | extern const NSNotificationName CDVViewDidLayoutSubviewsNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:55:14:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      55 | extern const NSNotificationName 
CDVViewWillTransitionToSizeNotification;
         |              ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:55:14:
 note: insert '_Nullable' if the
         pointer may be null
      55 | extern const NSNotificationName 
CDVViewWillTransitionToSizeNotification;
         |              ^
         |                                 _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:55:14:
 note: insert '_Nonnull' if the pointer
         should never be null
      55 | extern const NSNotificationName 
CDVViewWillTransitionToSizeNotification;
         |              ^
         |                                 _Nonnull
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:84:4:
 warning: pointer is missing a
         nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) 
[-Wnullability-completeness]
      84 | - (id)appDelegate;
         |    ^
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:84:4:
 note: insert '_Nullable' if the pointer
         may be null
      84 | - (id)appDelegate;
         |    ^
         |       _Nullable
   
/path/to/mobilespec/node_modules/cordova-ios/CordovaLib/include/Cordova/CDVPlugin.h:84:4:
 note: insert '_Nonnull' if the pointer
         should never be null
      84 | - (id)appDelegate;
         |    ^
         |       _Nonnull
   12 warnings generated.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to