erisu commented on PR #573:
URL: https://github.com/apache/cordova/pull/573#issuecomment-3665528974

   > I don't think it's true that I'm the only one who could edit the current 
diagram.
   
   I think what Tim is trying to say is that the current diagram is saved and 
served from your gist URL, and we don’t have permission to edit it.
   
   > But if I understand correctly any contributor should be able to fork the 
diagram and link a new version.
   
   What I think raphinesse is saying is that we can copy the diagram content 
from the gist and create a new Sketchviz diagram, and update the link in the 
README.
   
   ---
   
   I even created my own Sketchviz of this awhile back to test something. It 
could even be used if preferred. My graph had removed some things that I found 
less important in the usual Cordova workflow but could be re-added.
   
   [![Cordova Repo 
Graph](https://sketchviz.com/@erisu/a63ee48f8248e850063e694169b15005/7ec5a6607bced4d2d1d80ed32b03339eb43a4404.sketchy.png)](//sketchviz.com/@erisu/a63ee48f8248e850063e694169b15005)
   
   ---
   
   Either way, in my opinion, I have no preference between switching to Mermaid 
or continuing to use Sketchviz.
   
   This repository will never be published to the npm registry or displayed on 
the Apache Cordova website, so there should be no rendering issues if we use 
Mermaid.
   
   There may be issues in other repositories, but I wouldn’t worry about them 
until the graphs or images become outdated. Or any other issue that required 
review.
   
   While it would be nice to have one tool, that could render in all locations, 
I think it might not be as simple or easy. 
   
   If we wanted the diagrams to render correctly in all locations, we would 
likely need to install Graphviz locally, generate PNGs, and commit them to the 
repository. We would also need to save the corresponding DOT files. This 
approach might be less convenient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to