dpogue commented on code in PR #1115:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/1115#discussion_r2794869872
##########
src/ios/CDVWKInAppBrowser.m:
##########
@@ -18,7 +18,6 @@ Licensed to the Apache Software Foundation (ASF) under one
*/
#import "CDVWKInAppBrowser.h"
-#import <Cordova/CDVWebViewProcessPoolFactory.h>
Review Comment:
Maybe wrap this in `#if
__has_include(<Cordova/CDVWebViewProcessPoolFactory.h>)` just to be safe? That
should allow it to be compatible with future Cordova iOS majors
##########
src/ios/CDVWKInAppBrowser.m:
##########
@@ -117,7 +116,6 @@ - (void)openInInAppBrowser:(NSURL *)url
withOptions:(NSString *)options
NSDate *dateFrom = [NSDate dateWithTimeIntervalSince1970:0];
[dataStore removeDataOfTypes:[WKWebsiteDataStore allWebsiteDataTypes]
modifiedSince:dateFrom completionHandler:^{
NSLog(@"Removed all WKWebView data");
- self.inAppBrowserViewController.webView.configuration.processPool
= [[WKProcessPool alloc] init]; // create new process pool to flush all data
Review Comment:
Maybe do this conditionally on iOS <15? (although unclear if this is
actually needed or not...)
```objc
if (@available(iOS 15.0, *)) {
// Process Pool is deprecated and has no effect
} else {
self.inAppBrowserViewController.webView.configuration.processPool =
[[WKProcessPool alloc] init]; // create new process pool to flush all data
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
