dpogue commented on code in PR #1115:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/1115#discussion_r2809841425
##########
src/ios/CDVWKInAppBrowser.m:
##########
@@ -671,11 +684,16 @@ - (void)createViews
configuration.applicationNameForUserAgent = userAgent;
configuration.userContentController = userContentController;
-#if __has_include(<Cordova/CDVWebViewProcessPoolFactory.h>)
- configuration.processPool = [[CDVWebViewProcessPoolFactory sharedFactory]
sharedProcessPool];
-#elif __has_include("CDVWKProcessPoolFactory.h")
- configuration.processPool = [[CDVWKProcessPoolFactory sharedFactory]
sharedProcessPool];
-#endif
+ if (@available(iOS 15.0, *)) {
+ // Since iOS 15 WKProcessPool is deprecated and has no effect
+ } else {
+ // Set for iOS 14 and 15 a shared process pool
+ // CDVWebViewProcessPoolFactory is deprecated since cordova-ios 8.0.0
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+ configuration.processPool = [[CDVWebViewProcessPoolFactory
sharedFactory] sharedProcessPool];
Review Comment:
I think we need to keep the `#if
__has_include(<Cordova/CDVWebViewProcessPoolFactory.h>)` check here as well.
I'm not sure about whether the `#elif
__has_include("CDVWKProcessPoolFactory.h")` check is still necessary. That
would depend on what cordova-ios versions the plugin supports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
