ollm commented on issue #1967:
URL: 
https://github.com/apache/cordova-android/issues/1967#issuecomment-4907639226

   > Maybe we can add a workaround for `--safe-area-inset-*` beeing 0? The 
article 
https://medium.com/androiddevelopers/make-webviews-edge-to-edge-a6ef319adfac 
shows how to set `--safe-area-inset-*` css variables by JavaScript from the 
native code. This can be used if the safe-area-inset-* css environment 
variables are 0. Is this the only reason for using your custom plugin?
   
   This isn't a problem for me. After some time has passed, I'll probably 
switch completely to `env(safe-area-inset-*)` (Which I'm already using on iOS), 
although I'll continue using the custom plugin for the following features.
   
   - `StatusBar.overlaysWebView(true)`: I've always had the WebView fill the 
entire screen, with transparent/semi-transparent system bars on old Android 
versions that don't support edgeToEdge.
   - `StatusBar.styleLightContent()`: Changes the status bar icons to white 
when the app is using the dark theme, or when the light theme has a header 
image.
   - `StatusBar.styleDefault()`: Changes the status bar icons to black when the 
app is using the light theme.
   - `StatusBar.height()`: Returns the height of the status bar, since 
env(safe-area-inset-*) didn't previously work on Android.
   
   Out of all these, I do think `StatusBar.styleLightContent()` and 
`StatusBar.styleDefault()` should be implemented in the built-in plugin (On 
both iOS and Android), as they're often needed depending on the app's theme or 
design.
   
   I've attached a video showing an example of the use of `styleLightContent()` 
and `styleDefault()` in my app.
   
   
https://github.com/user-attachments/assets/5ed6c0ce-5790-4997-815f-37b9f743dc56


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to