dpogue commented on issue #1967: URL: https://github.com/apache/cordova-android/issues/1967#issuecomment-4908403650
A few thoughts here: 1. We should probably always determine the text colour based on the `StatusBarBackgroundColor` preference or the last (non-transparent) status bar background set via JS, even in E2E mode. That would at least provide a way to set the status bar colour (even if the status bar background isn't visible) to match the app and automatically determine the contrasting text colour. 2. On iOS, the built-in status bar implementation is entirely conditional on the `CDVStatusBar` class not existing in the app. I think on Android that ended up not being easy to do because the layout structure needed to change with E2E to support faking non-E2E on newer Android versions. The goal from my perspective was always that the core platform would provide enough to show/hide a solid background behind the status bar based (ideally) on the `viewport-fit` meta directive in the HTML, and that the background of that solid bar would be determined (ideally) by a `theme-color` meta directive in the HTML. The `window.statusbar.setBackgroundColor` API was added to allow apps to force it in places where `theme-color` isn't supported (iOS <15.4, Android all versions currently), and `window.statusbar.visible` is supported to show or hide the status bar background temporarily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
