ollm commented on PR #1983:
URL: https://github.com/apache/cordova-android/pull/1983#issuecomment-5091815695

   > I saw the native code is not in a `StatusBarPlugin`, it's in a 
`SystemBarPlugin`. So the navigation bar code could be handled there also. 
Maybe `statusbar.js` could be changed to `systembar.js`, also. The call for 
changing the navigation bar could be done over `windows.navigationbar`?
   
   I think that would be the best approach, since I'm already reusing some 
functions from `SystemBarPlugin`.
   
   I've also made the passed color be applied as the background color of the 
view 
https://github.com/ollm/cordova-android/commit/61e2295c39cc87a37bc6b29cf8071fec11b4d40c.
 This should mitigate/resolve the following issue 
https://github.com/apache/cordova-android/issues/1946


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to