erisu commented on PR #1983: URL: https://github.com/apache/cordova-android/pull/1983#issuecomment-5105620309
> @erisu What do you think? I'll try to find some time to test the current behavior and the changes in this PR as well. > I saw the native code is not in a `StatusBarPlugin`, it's in a `SystemBarPlugin`. So the navigation bar code could be handled there also. Maybe `statusbar.js` could be changed to `systembar.js`, also. The call for changing the navigation bar could be done over `windows.navigationbar`? My suggestion would be to avoid adding this to `statusbar.js` and to keep the file name as it is. Since the module is clobbered onto the `window.statusbar` object, it makes sense for it to contain status bar-related functionality only and the filename match its purpose. Additionally, the iOS implementation follows the same approach, so keeping this structure would also maintain consistency across platforms. Instead, one possible approach would be to introduce a new `navigationbar.js` file and clobber it onto the `window.navigationbar` object. The API could then be something like `window.navigationbar.setBackgroundColor()`. I also did a quick search and couldn't find any web standard that defines `window.navigationbar`, so it seems like it would be available for us to use. I don't see any issue with both `statusbar.js` and `navigationbar.js` pointing to the same native-side class since the class is dedicated to all System Bars. Again, I will try to find some time to look more in-depth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
