[ 
https://issues.apache.org/jira/browse/CB-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817223#comment-13817223
 ] 

Bas Bosman commented on CB-5063:
--------------------------------

Commit 3a4c978e10214868210b13a1144ca0ae0d9b99a1  introduced unintended side 
effects, as it copies the platform cordova.js before the www contents, while it 
used to be the other way around.

I use a cordova.js shim in my www directory to allow testing stuff in the 
browser. In the old situation it would be overwritten with the platform version 
while running prepare. In the new situation the shim would overwrite the 
platform version.

Could the order be changed back to the previous behavior?

> "Prepare" should not depend on the ~/.cordova/libs directory
> ------------------------------------------------------------
>
>                 Key: CB-5063
>                 URL: https://issues.apache.org/jira/browse/CB-5063
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Andrew Grieve
>            Assignee: Mark Koudritsky
>            Priority: Minor
>
> Look in src/metadata/*_parser.js
> They all have logic in `update_www()` to copy the cordova.js file from 
> util.libDirectory.
> When users change machines, this turns into an error since the ~/.lib 
> directory is not populated.
> On iOS, the fix is trivial - a copy of cordova.js already exists at 
> platforms/ios/CordovaLib/cordova.js
> For other platforms, we could trivially fix the problem just by not blowing 
> away the www/cordova.js file during prepare, but I think it would be better 
> to not rely on that since likely people should not be committing the 
> generated www/ into source control.
> Instead, let's ensure that all platforms keep a copy of their cordova.js file 
> within their platform/ directory and use copy that into www/ during prepare.
> We could maybe even get rid of the custom logic entirely by putting the 
> cordova.js file within `merges/` upon `platform add`.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to