[
https://issues.apache.org/jira/browse/CB-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817521#comment-13817521
]
Mark Koudritsky commented on CB-5063:
-------------------------------------
Review request for reverting to original order of copying
https://reviews.apache.org/r/15354/
It's now the same as it was before the previous commit.
But there is some inconsistency between the platforms in that original behavior:
On windows platforms merges are dealt with inside update_www() and cordova.js
is copied after the merges.
On other platforms update_www() is called before plugman, but the mearges are
daelt with from update_project() that is called after plugman and therefore
cordova.js is copied before the merges.
On windows8
update_www is called twice, second time is from update_project(), and as far as
I understand the second time it should wipe all the changes introduced by
plugman in platform www.
> "Prepare" should not depend on the ~/.cordova/libs directory
> ------------------------------------------------------------
>
> Key: CB-5063
> URL: https://issues.apache.org/jira/browse/CB-5063
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Reporter: Andrew Grieve
> Assignee: Mark Koudritsky
> Priority: Minor
>
> Look in src/metadata/*_parser.js
> They all have logic in `update_www()` to copy the cordova.js file from
> util.libDirectory.
> When users change machines, this turns into an error since the ~/.lib
> directory is not populated.
> On iOS, the fix is trivial - a copy of cordova.js already exists at
> platforms/ios/CordovaLib/cordova.js
> For other platforms, we could trivially fix the problem just by not blowing
> away the www/cordova.js file during prepare, but I think it would be better
> to not rely on that since likely people should not be committing the
> generated www/ into source control.
> Instead, let's ensure that all platforms keep a copy of their cordova.js file
> within their platform/ directory and use copy that into www/ during prepare.
> We could maybe even get rid of the custom logic entirely by putting the
> cordova.js file within `merges/` upon `platform add`.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
