[
https://issues.apache.org/jira/browse/CB-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926164#comment-13926164
]
ASF GitHub Bot commented on CB-3208:
------------------------------------
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10448723
--- Diff: autotest/tests/contacts.tests.js ---
@@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)", function ()
{
});
// HACK: there is a reliance between the previous and next test.
This is bad form.
it("contacts.spec.21 update a contact", function() {
-
// this api requires manual user confirmation on WP7/8 so skip
it
if (isWindowsPhone) return;
- expect(gContactObj).toBeDefined();
+ var bDay = new Date(1976, 6,4);
--- End diff --
You "moved" a rather similar line:
372 - var bDay = new Date(1975, 5,4);
to:
381 + var bDay = new Date(1976, 6,4);
I assumed it was a straightforward move (I was too lazy to verify that it
wasn't a straightforward move).
I wanted to acknowledge that I was aware that your source didn't have good
style -- i.e. it wasn't precisely your fault that there was a space missing.
> contacts
> --------
>
> Key: CB-3208
> URL: https://issues.apache.org/jira/browse/CB-3208
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: FirefoxOS
> Affects Versions: 2.6.0
> Reporter: Herm Wong
> Assignee: Herm Wong
> Fix For: 3.4.0
>
>
> Contacts API spec: https://wiki.mozilla.org/WebAPI/ContactsAPI
--
This message was sent by Atlassian JIRA
(v6.2#6252)
