[ https://issues.apache.org/jira/browse/CB-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926299#comment-13926299 ]
ASF GitHub Bot commented on CB-3208: ------------------------------------ Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10452942 --- Diff: autotest/tests/contacts.tests.js --- @@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)", function () { }); // HACK: there is a reliance between the previous and next test. This is bad form. it("contacts.spec.21 update a contact", function() { - // this api requires manual user confirmation on WP7/8 so skip it if (isWindowsPhone) return; - expect(gContactObj).toBeDefined(); + var bDay = new Date(1976, 6,4); --- End diff -- Sure, don't worry about this. Just fix the space :) Also, I'm assuming that 'bDay' is birthday, I'd suggest using two distinct variables for the two dates with names that are sufficiently descriptive for people to understand what you're doing. > contacts > -------- > > Key: CB-3208 > URL: https://issues.apache.org/jira/browse/CB-3208 > Project: Apache Cordova > Issue Type: Sub-task > Components: FirefoxOS > Affects Versions: 2.6.0 > Reporter: Herm Wong > Assignee: Herm Wong > Fix For: 3.4.0 > > > Contacts API spec: https://wiki.mozilla.org/WebAPI/ContactsAPI -- This message was sent by Atlassian JIRA (v6.2#6252)