[
https://issues.apache.org/jira/browse/CB-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942468#comment-13942468
]
ASF GitHub Bot commented on CB-6272:
------------------------------------
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/66#discussion_r10821128
--- Diff: spec/plugins/dependencies/meta/D/plugin.xml ---
@@ -0,0 +1,61 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Copyright 2013 Anis Kadri
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+
+<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0";
+ xmlns:android="http://schemas.android.com/apk/res/android";
+ id="D"
+ version="0.6.0">
+
+ <name>Plugin D</name>
+
+ <asset src="www/plugin-d.js" target="plugin-d.js" />
+
+ <config-file target="config.xml" parent="/*">
+ <access origin="build.phonegap.com" />
+ </config-file>
+
+ <engines>
+ <engine name="cordova" version=">=1.0.0"/>
+ </engines>
+
+ <!-- android -->
+ <platform name="android">
+ <config-file target="res/xml/config.xml" parent="plugins">
+ <plugin name="D"
+ value="com.phonegap.D.D"/>
+ </config-file>
+
+ <source-file src="src/android/D.java"
+ target-dir="src/com/phonegap/D" />
+ </platform>
+
+
--- End diff --
This introduces trailing whitespace. Please don't.
> Fix subdir handling
> -------------------
>
> Key: CB-6272
> URL: https://issues.apache.org/jira/browse/CB-6272
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Affects Versions: 3.5.0
> Reporter: Josh Soref
> Assignee: Jonathan Bond
> Priority: Blocker
>
> CB-6160 landed [~jbondc]'s ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
> which broke some portion of install:
> + if (dep.subdir) {
> + dep.subdir = path.join(dep.subdir.split('/'));
> ...
> - if (dep_subdir) {
> - dep_subdir = path.join.apply(null,
> dep_subdir.split('/'));
--
This message was sent by Atlassian JIRA
(v6.2#6252)
