[
https://issues.apache.org/jira/browse/CB-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942474#comment-13942474
]
ASF GitHub Bot commented on CB-6272:
------------------------------------
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/66#discussion_r10821172
--- Diff: src/install.js ---
@@ -413,7 +445,7 @@ function tryFetchDependency(dep, install) {
// CB-4770: registry fetching
if(dep.url === undefined) {
- dep.url = dep.plugin_id;
+ dep.url = dep.id;
--- End diff --
This introduces trailing whitespace. Please don't.
> Fix subdir handling
> -------------------
>
> Key: CB-6272
> URL: https://issues.apache.org/jira/browse/CB-6272
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Affects Versions: 3.5.0
> Reporter: Josh Soref
> Assignee: Jonathan Bond
> Priority: Blocker
>
> CB-6160 landed [~jbondc]'s ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
> which broke some portion of install:
> + if (dep.subdir) {
> + dep.subdir = path.join(dep.subdir.split('/'));
> ...
> - if (dep_subdir) {
> - dep_subdir = path.join.apply(null,
> dep_subdir.split('/'));
--
This message was sent by Atlassian JIRA
(v6.2#6252)
