[
https://issues.apache.org/jira/browse/CB-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944465#comment-13944465
]
ASF GitHub Bot commented on CB-6326:
------------------------------------
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38387520
Thanks a lot for pointing this out. When manually adding a simulator using
the "blackberry10/bin/target add" command, it is added with "simulator", but
the simulator detection logic in run-utils.js is using "emulator".
I'm fine with making "emulator" the default in blackberry10.json.
Please checkout my commit below which is an addition to yours. I believe it
covers all use cases, including fixing older files.
https://github.com/blackberry/cordova-blackberry/commit/7b563950c1c2612838b37d81c906f286384ae0bc
> [cordova-blackberry] target-utils.js outdated
> ---------------------------------------------
>
> Key: CB-6326
> URL: https://issues.apache.org/jira/browse/CB-6326
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
> Affects Versions: 3.4.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Priority: Blocker
> Labels: blackberry-utils, blackberry10, cordova-cli, cordova-info
> Fix For: 3.5.0
>
>
> The file target-utils.js, located under cordova/lib, is used to get
> information a about the devices, emulators, even if those are registered in
> the blackberry10.json file.
> When a cordova application is created, build and then deployed into the
> blackberry emulator or device, all records stays at the blackberry10.json
> file, that information include description, ip, pin, and type. When emulate,
> it sets 'emulator', target-utils.js it looks for this file and check the
> content, and it's looking for the word 'simulator', so it won't work anymore
> if this word is not chaged, and replaced for 'emulator'.
> Besides, from this change it depends this issue:
> https://issues.apache.org/jira/browse/CB-6121
> The cordova info command it will use the target-utils.js, to add support for
> blackberry10.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
