[
https://issues.apache.org/jira/browse/CB-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944595#comment-13944595
]
ASF GitHub Bot commented on CB-6326:
------------------------------------
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/151#issuecomment-38398324
Excellent, thanks to you Bryan, for taking the time to review this, and for
resolve the inconsistency with the others js file. Having it so, it won't
present any inconsistency between manually added vs auto-detected as you
pointed in the commit.
Thanks a lot again for taking the time to fix this out. I assume that you
are able to merge this commits, it would be great if you do so, to close this
subject.
Regards.
Martin.
> [cordova-blackberry] target-utils.js outdated
> ---------------------------------------------
>
> Key: CB-6326
> URL: https://issues.apache.org/jira/browse/CB-6326
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
> Affects Versions: 3.4.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Priority: Blocker
> Labels: blackberry-utils, blackberry10, cordova-cli, cordova-info
> Fix For: 3.5.0
>
>
> The file target-utils.js, located under cordova/lib, is used to get
> information a about the devices, emulators, even if those are registered in
> the blackberry10.json file.
> When a cordova application is created, build and then deployed into the
> blackberry emulator or device, all records stays at the blackberry10.json
> file, that information include description, ip, pin, and type. When emulate,
> it sets 'emulator', target-utils.js it looks for this file and check the
> content, and it's looking for the word 'simulator', so it won't work anymore
> if this word is not chaged, and replaced for 'emulator'.
> Besides, from this change it depends this issue:
> https://issues.apache.org/jira/browse/CB-6121
> The cordova info command it will use the target-utils.js, to add support for
> blackberry10.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
