[ 
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032262#comment-14032262
 ] 

ASF GitHub Bot commented on CB-3571:
------------------------------------

Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371
  
    The usage LGTM. But does current implementation remove all default cordova 
splash screen images if there is no splash element defined?
    Also, on Android icons and splash images definitions are very similar, but 
we use two different code blocks for icons and splashIcons. There is probably a 
way to move common logic to special function and then call it for icons and 
splash screens.


> Add support for <splash> elements in config.xml
> -----------------------------------------------
>
>                 Key: CB-3571
>                 URL: https://issues.apache.org/jira/browse/CB-3571
>             Project: Apache Cordova
>          Issue Type: Wish
>          Components: CLI
>    Affects Versions: Master
>            Reporter: Michael Brooks
>            Assignee: Mark Koudritsky
>
> Similar to adding support for the {{<icon>}} element, we should add support 
> for the splash screen.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to