[
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037423#comment-14037423
]
ASF GitHub Bot commented on CB-3571:
------------------------------------
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/30#discussion_r13974255
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -88,13 +88,54 @@ module.exports.prototype = {
fs.writeFileSync(this.strings, strings.write({indent: 4}),
'utf-8');
events.emit('verbose', 'Wrote out Android application name to "' +
name + '"');
+ var projectRoot = util.isCordova(this.path);
+
+ var splashIcons = config.getIcons('android', 'splash');
+ // if there are icon elements in config.xml
+ if (splashIcons) {
+ events.emit('verbose', "splash icons: " +
JSON.stringify(splashIcons));
--- End diff --
This line seems to be indented with 3 spaces. Please use consistent 4 space
indentation.
A suggestion: the whole splashScreen section seems to be long enough to
live in a function of its own. Preferably in such a way so that it can be
shared with Amazon FireOS parser, or whatever Android derivative wants to use
it.
> Add support for <splash> elements in config.xml
> -----------------------------------------------
>
> Key: CB-3571
> URL: https://issues.apache.org/jira/browse/CB-3571
> Project: Apache Cordova
> Issue Type: Wish
> Components: CLI
> Affects Versions: Master
> Reporter: Michael Brooks
> Assignee: Lorin Beer
>
> Similar to adding support for the {{<icon>}} element, we should add support
> for the splash screen.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
