[
https://issues.apache.org/jira/browse/CB-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033776#comment-14033776
]
ASF GitHub Bot commented on CB-6954:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/31
CB-6954 Share events.js between cordova and plugman
https://issues.apache.org/jira/browse/CB-6954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-6954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 97d8a86eb5c39f94e43d071630d04292db054757
Author: sgrebnov <[email protected]>
Date: 2014-06-17T13:32:24Z
CB-6954 Share events.js between cordova and plugman
----
> Share events.js between cordova and plugman
> -------------------------------------------
>
> Key: CB-6954
> URL: https://issues.apache.org/jira/browse/CB-6954
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova, cordova-lib, plugman, refactoring
>
> Currently there are two instances of events.js under cordova and plugman
> folders which provide exactly the same functionality.
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/events.js
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/events.js
> This is common functionality which must be shared among cordova and plugman
> so must be moved to some common folder (src/events.js???). Similar to
> CordovaError and xml-helpers.js
> It is also required to be able to reference to 'events' from shared code - as
> an example, common Hooks code which emits messages via 'events'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
