[
https://issues.apache.org/jira/browse/CB-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035807#comment-14035807
]
ASF subversion and git services commented on CB-6954:
-----------------------------------------------------
Commit c7a6435193c354870487e5fed399c9c1e9754aa2 in cordova-cli's branch
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=c7a6435 ]
CB-6954: Use the unified cordova_lib.events
After events got shared between cordova and plugman, some log messages were
printed multiple times since handlers were registered twice in the cli:
cordova.on(...)
plugman.on(...)
changing it to
events.on(...)
> Share events.js between cordova and plugman
> -------------------------------------------
>
> Key: CB-6954
> URL: https://issues.apache.org/jira/browse/CB-6954
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova, cordova-lib, plugman, refactoring
>
> Currently there are two instances of events.js under cordova and plugman
> folders which provide exactly the same functionality.
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/events.js
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/events.js
> This is common functionality which must be shared among cordova and plugman
> so must be moved to some common folder (src/events.js???). Similar to
> CordovaError and xml-helpers.js
> It is also required to be able to reference to 'events' from shared code - as
> an example, common Hooks code which emits messages via 'events'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
