[
https://issues.apache.org/jira/browse/CB-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061534#comment-14061534
]
ASF GitHub Bot commented on CB-7132:
------------------------------------
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/58#discussion_r14914123
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -42,6 +42,12 @@ module.exports = function android_parser(project) {
this.android_config = path.join(this.path, 'res', 'xml', 'config.xml');
};
+// Returns a promise.
+module.exports.check_requirements = function(project_root) {
+ // Rely on platform's bin/create script to check requirements.
+ return Q(true);
+};
+
--- End diff --
Is this intentional or a merge artifact?
The check_reqs functions were all removed as part of CB-7091
commits:
https://github.com/apache/cordova-lib/commit/ab49973560ccb7a1ea37d9f5db4e497ef0ce92d1
https://github.com/apache/cordova-lib/commit/153092f2c235185c7f141979a550779800954a92
> Single default icon overridden by Cordova icon on Android
> ----------------------------------------------------------
>
> Key: CB-7132
> URL: https://issues.apache.org/jira/browse/CB-7132
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CLI
> Affects Versions: 3.5.0
> Reporter: Bryan Higgins
> Assignee: Axel Nennker
>
> Behaviour has changed between 3.5.0-0.2.4 and 3.5.0-0.2.6 resulting in the
> "single default icon" [1] not being displayed on device.
> In 3.5.0-0.2.4 the icon was copied into drawable-*
> In 3.5.0-0.2.6 the icon is copied to drawable/
> The template [2] already contains default icons for drawable-*, thus the
> single default icon is never used.
> [1] http://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html
> [2]
> https://github.com/apache/cordova-android/tree/master/bin/templates/project/res
--
This message was sent by Atlassian JIRA
(v6.2#6252)
