[
https://issues.apache.org/jira/browse/CB-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066832#comment-14066832
]
ASF GitHub Bot commented on CB-7132:
------------------------------------
Github user VVelda commented on the pull request:
https://github.com/apache/cordova-lib/pull/58#issuecomment-49475950
Now it works good with icons. But I have one question, you plain that your
changes removes splashcreen from project, if in config.xml is blank <splash />
tag, don't you?
But if I do it and then call cordova prepare, it do, what it shoudl do, but
also error occurs:
shell.js: internal error
TypeError: Cannot use 'in' operator to search for 'length' in undefined
at Object._cp
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\node_modules\shelljs\shell.js:267:26)
at Object.cp
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\node_modules\shelljs\shell.js:1491:23)
at Object.module.exports.handleSplashes
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\metadata\android_parser.js:115:11)
at Object.module.exports.update_from_config
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\metadata\android_parser.js:228:14)
at Object.module.exports.update_project
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\metadata\android_parser.js:337:18)
at
C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\prepare.js:116:31
at _fulfilled
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:798:54)
at self.promiseDispatch.done
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:827:30)
at Promise.promise.promiseDispatch
(C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:760:13)
at
C:\Users\Velda\AppData\Roaming\npm\node_modules\cordova\node_modules\q\q.js:821:14
I don't know if it's problem with code, or I'm missing something. (I have
updated only android-parser.js to test it)
> Single default icon overridden by Cordova icon on Android
> ----------------------------------------------------------
>
> Key: CB-7132
> URL: https://issues.apache.org/jira/browse/CB-7132
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CLI
> Affects Versions: 3.5.0
> Reporter: Bryan Higgins
> Assignee: Axel Nennker
>
> Behaviour has changed between 3.5.0-0.2.4 and 3.5.0-0.2.6 resulting in the
> "single default icon" [1] not being displayed on device.
> In 3.5.0-0.2.4 the icon was copied into drawable-*
> In 3.5.0-0.2.6 the icon is copied to drawable/
> The template [2] already contains default icons for drawable-*, thus the
> single default icon is never used.
> [1] http://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html
> [2]
> https://github.com/apache/cordova-android/tree/master/bin/templates/project/res
--
This message was sent by Atlassian JIRA
(v6.2#6252)
