[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112252#comment-14112252
]
Ian Clelland commented on CB-7375:
----------------------------------
Okay, the lesson here is that the code is fragile, and the conditions for it to
work are not well defined.
We can do one of two things here:
1. Add some more tests, to test the return from the exec call itself, to
validate that it is well-formed for the rest of the JavaScript code in Entry.js
2. Move some of the WP8 implementation into a separate file,
{{www/wp/Entry.js}} so that it can do what it needs to.
I feel like #1 is wrong -- that it's the wrong level to test things at, but I
suppose that the exec return value *is* an API surface in this case, since
there are multiple clients that need to work with it in an interoperable
fashion. #2 is also not very DRY, unless we can factor out just the "call exec
and get something back" part.
> Investigate breaking changes at file plugin
> -------------------------------------------
>
> Key: CB-7375
> URL: https://issues.apache.org/jira/browse/CB-7375
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Assignee: Ian Clelland
> Labels: file
> Fix For: 3.6.0
>
>
> Some of the changes made lately to file plugin with this commit:
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
> Are breaking changes to this plugin, affecting other platforms as android.
> Running mobile spec after that specific commit, 4 file tests are failing
> (test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
