[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112278#comment-14112278
]
Ian Clelland commented on CB-7375:
----------------------------------
The only change I made in resolveLocalFileSystemURL was to the filesystem name
detection code. Before Vladimir's changes, it was:
{code}
var fsName = entry.filesystemName || (entry.filesystem == window.PERSISTENT ?
'persistent' : 'temporary');
{code}
Vladimir changed it to
{code}
var fsName = (entry.filesystem && entry.filesystem.name) || (entry.filesystem
== window.PERSISTENT ? 'persistent' : 'temporary');
{code}
For consistency with the code in Entry, I combined the two, and changed it to:
{code}
var fsName = entry.filesystemName || (entry.filesystem &&
entry.filesystem.name) || (entry.filesystem == window.PERSISTENT ? 'persistent'
: 'temporary');
{code}
The only way that I can see this breaking WP8 (or changing anything at all,
actually,) is if the {{filesystemName}} property is being set to something by
the {{resolveLocalFileSystemURI}} {{exec()}} call. It isn't (the string
"filesystemName") doesn't seem to appear at all in the C# code, so I'm not sure
what's going on that's causing these failures. I suspect that
{{resolveLocalFileSystemURI}} is always failing now (the tests which expect
failure are generally passing) but I'd need to see the CI output to know for
sure.
> Investigate breaking changes at file plugin
> -------------------------------------------
>
> Key: CB-7375
> URL: https://issues.apache.org/jira/browse/CB-7375
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Assignee: Ian Clelland
> Labels: file
> Fix For: 3.6.0
>
>
> Some of the changes made lately to file plugin with this commit:
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
> Are breaking changes to this plugin, affecting other platforms as android.
> Running mobile spec after that specific commit, 4 file tests are failing
> (test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
